<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103764/">http://git.reviewboard.kde.org/r/103764/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 22nd, 2012, 9:09 p.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I disagree, at least for the review-area. Maybe its ok if the review area is not needed anymore (i.e. the patch is comitted, no local changes anymore), but then the user would've ended up in the code area anyway before closing kdevelop.
Maybe for the debug area kdevelop should rather start the debugee(s) that where left running again?</pre>
</blockquote>
<p>On January 22nd, 2012, 10:18 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm... well for my perspective, these areas are places where you go to. Likewise, I never go from debug -> commit (even though it's possible).
Also I think it's not possible to restore the Patch Review state at the moment, so if you restore to Review, you get quite a useless screen (yes, I understand this patch is not fixing this, but it's a collateral effect).
I think Niko's change makes sense. I wouldn't put it in 1.3 though, sounds more like a wish to me.</pre>
</blockquote>
<p>On January 23rd, 2012, 7:40 p.m., <b>Niko Sams</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restoring as much as possible on restart is good. But restoring the debugger is impossible. Starting the debugee again could be done but would be to me - as a user - confusing if not irritating (what if the debugee triggers some unwanted action?)
If restoring the review is possible I don't know. Also think about changed repositories, ie. when the users commited changes outside kdevelop.</pre>
</blockquote>
<p>On January 26th, 2012, 9:35 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm also with Niko here, don't restore the debugger. The review thingy though should not happen. so there I'm with apaku :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But restoring the review isn't implemented!
Start a review by commiting (without actually committing) and restart kdevelop. You end up with an empty Patch Reivew Tool view.</pre>
<br />
<p>- Niko</p>
<br />
<p>On January 22nd, 2012, 5:07 p.m., Niko Sams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Niko Sams.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2012, 5:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Areas are used in a workflow:
- debugging
- commiting/patch reviewing
and kdevelop switches automatically to that area (and back)
Now when I have a running debug session (and debug area is opened) and I quit kdevelop, it will remember debug as active area and restore it on start.
That doesn't make much sense in the way areas are used now, so my patch removes that functionality.
...ok to go into 1.3?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/uicontroller.cpp <span style="color: grey">(2091fdf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103764/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>