Activating Documents with a range is broken since d77c94c1402916f8f00b02104f71187330548ecd

Milian Wolff mail at milianw.de
Wed Dec 12 19:37:26 UTC 2012


On Wednesday 12 December 2012 20:25:01 Andreas Pakulat wrote:
> Hi,
> 
> just bisected why double-clicking entries in the grepview does not
> work anymore as it should. Turns out that
> DocumentController::activateDocument( doc, range ) does not jump to
> the range anymore, unless the document is not open yet. Anybody
> understands the logic thats involved and can fix that? Otherwise I'll
> revert this over the weekend.
> 
> That also makes me wonder wether we maybe should reconsider all of the
> refactorings that Aleix did in this area, this is not the first
> regression it caused and the main benefit of lazily initializing views
> is not usable at the moment either (see my contextmenu related mail)?

I'd also consider that this second breakage means the changes hit master too 
soon. Please revert them, put them into a branch, and lets investigate it 
there.

Cheers
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121212/b7270760/attachment.sig>


More information about the KDevelop-devel mailing list