Review Request: Document switcher plugin improvement

Jarosław Sierant jaroslaw.sierant at gmail.com
Fri Dec 7 17:25:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107628/
-----------------------------------------------------------

Review request for KDevelop.


Summary (updated)
-----------------

Document switcher plugin improvement


Description (updated)
-------

Document switcher window width is automatically calculated base on content (auto adjust to longest item). Current screen width is upper bound of the window width.

Code duplication has been removed (methods walkForward/walkBackward).

A path to the file on items list can be truncated if it is too long (threshold=80).


Diffs (updated)
-----

  plugins/documentswitcher/documentswitcherplugin.h 0924e81 
  plugins/documentswitcher/documentswitcherplugin.cpp d457a5a 

Diff: http://git.reviewboard.kde.org/r/107628/diff/


Testing (updated)
-------

Only manual tests are done.


Thanks,

Jarosław Sierant

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121207/74d44b19/attachment.html>


More information about the KDevelop-devel mailing list