Review Request: Parse error & warning messages generated by Free Pascal

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107613/#review23087
-----------------------------------------------------------


Imo the regexp is too generic, it should include the Error, Warning, Fatal strings at least. Furthermore please add a test for that (FilteringStrategyTest).

- Milian Wolff


On Dec. 6, 2012, 2:42 p.m., Pär-Ola Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107613/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2012, 2:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Parse error & warning messages generated by Free Pascal which looks like the following rows
> With this patch clicking on the error & warning lines will bring you to the correct line & column.
> 
> 
> pc -g -Tlinux -Sx -Mobjfpc iono
> Free Pascal Compiler version 2.6.0-6 [2012/08/09] for x86_64
> Copyright (c) 1993-2011 by Florian Klaempfl and others
> Target OS: Linux for x86-64
> Compiling iono.pas
> iono.pas(746,5) Warning: unreachable code
> iono.pas(750,5) Warning: unreachable code
> iono.pas(1166,16) Error: Illegal expression
> iono.pas(1175) Fatal: There were 1 errors compiling module, stopping
> Fatal: Compilation aborted
> Error: /usr/bin/ppcx64 returned an error exitcode (normal if you did not specify a source file to be compiled)
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 567bc62 
> 
> Diff: http://git.reviewboard.kde.org/r/107613/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pär-Ola Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121206/3092793b/attachment.html>