<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107613/">http://git.reviewboard.kde.org/r/107613/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Imo the regexp is too generic, it should include the Error, Warning, Fatal strings at least. Furthermore please add a test for that (FilteringStrategyTest).</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 6th, 2012, 2:42 p.m., Pär-Ola Nilsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Pär-Ola Nilsson.</div>
<p style="color: grey;"><i>Updated Dec. 6, 2012, 2:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parse error & warning messages generated by Free Pascal which looks like the following rows
With this patch clicking on the error & warning lines will bring you to the correct line & column.
pc -g -Tlinux -Sx -Mobjfpc iono
Free Pascal Compiler version 2.6.0-6 [2012/08/09] for x86_64
Copyright (c) 1993-2011 by Florian Klaempfl and others
Target OS: Linux for x86-64
Compiling iono.pas
iono.pas(746,5) Warning: unreachable code
iono.pas(750,5) Warning: unreachable code
iono.pas(1166,16) Error: Illegal expression
iono.pas(1175) Fatal: There were 1 errors compiling module, stopping
Fatal: Compilation aborted
Error: /usr/bin/ppcx64 returned an error exitcode (normal if you did not specify a source file to be compiled)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/outputfilteringstrategies.cpp <span style="color: grey">(567bc62)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107613/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>