Review Request: Cleanup "~/.cache/kdevduchain/<session>" on session remove (+refactor allocateRepository()).

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106945/#review22934
-----------------------------------------------------------



language/duchain/repositories/itemrepository.cpp
<http://git.reviewboard.kde.org/r/106945/#comment17526>

    As I said, this should not happen. You never want multiple item repository registries - it should be a singleton or similar (probably there is a static getter so far, could also be refactored).
    
    generally, if you work on such a refactoring - keep your commits small, I think reviewboard won't be the right place in the end, rather paste a link to your branch on our devel ml and we'll review it there I think.



language/duchain/repositories/itemrepository.cpp
<http://git.reviewboard.kde.org/r/106945/#comment17527>

    It should not be allowed to create multiple ItemRepositoryRegistries.
    
    Also, while refactoring, make sure to use many small commits which should make it much simpler to follow the refactoring later on.


- Milian Wolff


On Oct. 29, 2012, 2:19 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106945/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 2:19 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> 1. Clean (rmdir) the per-session duchain store on session removal (particularly useful in unit-tests and their temporary sessions).
> 2. Partially refactor allocateRepository() (separate cache path compution into a different function, fix formatting, handle lockfiles properly)
> 
> Don't know if I've done that properly, but I wanted to avoid mentioning ".cache/kdevduchain" in two unrelated places.
> 
> 
> Diffs
> -----
> 
>   language/duchain/repositories/itemrepository.h 392847c 
>   language/duchain/repositories/itemrepository.cpp 8d559cf 
>   shell/session.cpp a59d70e 
> 
> Diff: http://git.reviewboard.kde.org/r/106945/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121203/1aed0c07/attachment.html>