Review Request: Make watched debugger variables user-editable (#257343)

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107158/#review22918
-----------------------------------------------------------


Sorry for the late review.


debuggers/gdb/gdbvariable.cpp
<http://git.reviewboard.kde.org/r/107158/#comment17490>

    - the value needs to be quoted.
    - some error handling would be good - to show the user if the assign failed



debuggers/gdb/gdbvariable.cpp
<http://git.reviewboard.kde.org/r/107158/#comment17489>

    Reload should be done using a proper -var-update.


- Niko Sams


On Oct. 31, 2012, 4:31 p.m., Enver Haase wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107158/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 4:31 p.m.)
> 
> 
> Review request for KDevelop and Niko Sams.
> 
> 
> Description
> -------
> 
> Used together with my patch for KDevPlatform.
> Closes https://bugs.kde.org/show_bug.cgi?id=257343
> making watched debugger variables user-editable.
> 
> 
> This addresses bug 257343.
>     http://bugs.kde.org/show_bug.cgi?id=257343
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/_abstractvariableitem.h 9ccdd03 
>   debuggers/gdb/_abstractvariableitem.cpp 4502393 
>   debuggers/gdb/_variableitem.h 8285d1f 
>   debuggers/gdb/_variableitem.cpp 4cd3921 
>   debuggers/gdb/_watchitem.h 3e26038 
>   debuggers/gdb/_watchitem.cpp 83eecd3 
>   debuggers/gdb/gdbvariable.h 9a6fb11 
>   debuggers/gdb/gdbvariable.cpp a98e25d 
> 
> Diff: http://git.reviewboard.kde.org/r/107158/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Enver Haase
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121202/f4bd2b26/attachment-0001.html>