Review Request: Make watched debugger variables user-editable (#257343)

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107157/#review22916
-----------------------------------------------------------


Sorry for the late review.


debugger/util/treeitem.h
<http://git.reviewboard.kde.org/r/107157/#comment17485>

    this should be in KDevelop::Variable, see comment in TreeModel



debugger/util/treeitem.h
<http://git.reviewboard.kde.org/r/107157/#comment17484>

    this should be in KDevelop::Variable, see comment in TreeModel
    
    and rename it to sendValue or something.



debugger/util/treemodel.h
<http://git.reviewboard.kde.org/r/107157/#comment17483>

    Interesting, that's unused. Please also remove TreeModel::setEditable.
    
    (this should be a separate commit)



debugger/util/treemodel.cpp
<http://git.reviewboard.kde.org/r/107157/#comment17487>

    That's too Variable specific, move it to VariableCollection - there it's ok to implement this column==1 logic



debugger/util/treemodel.cpp
<http://git.reviewboard.kde.org/r/107157/#comment17488>

    Also move to VariableCollection


- Niko Sams


On Oct. 31, 2012, 4:27 p.m., Enver Haase wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107157/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 4:27 p.m.)
> 
> 
> Review request for KDevelop and Niko Sams.
> 
> 
> Description
> -------
> 
> This patch is used together with my KDevelop patch and re-adds editable watched variable while debugging.
> Closes https://bugs.kde.org/show_bug.cgi?id=257343
> 
> 
> This addresses bug 257343.
>     http://bugs.kde.org/show_bug.cgi?id=257343
> 
> 
> Diffs
> -----
> 
>   debugger/util/treeitem.h 5c40fdd 
>   debugger/util/treemodel.h 7679da0 
>   debugger/util/treemodel.cpp 697de02 
>   debugger/variable/variablecollection.h add0380 
> 
> Diff: http://git.reviewboard.kde.org/r/107157/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Enver Haase
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121202/2ce50ca1/attachment.html>