Review Request: CMake: un-hack multiple builders support (i. e. ninja/make).

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106156/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

There are two TODOs regarding builder selection (ninja vs make vs maybe_eventually_something_else):
- CMakeBuilder::builderForProject()
- CMake::checkForNeedingConfigure()

This adds new code to correctly determine a builder used in project instead of taking some blind assumptions. Also, I've added a configuration key to make it possible to select builder for each build directory (though there is no UI for such setting).

Reason for changes: TODOs and incorrect handling of empty build-directory when Ninja (non-Makefile) is globally selected. If the directory is pruned and then configured through building, it is configured as Ninja, but built with make.

And a question: should we ever attempt to write auto-guessed builder to the config file to "remember" it?

P. S.: the patch-set is provided to make it easier to inspect the changes one by one.


Diffs
-----

  projectbuilders/cmakebuilder/CMakeLists.txt 07807ed 
  projectbuilders/cmakebuilder/cmakebuilder.cpp b70458d 
  projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp 63b8e8c 
  projectmanagers/cmake/cmakemanager.cpp e7ab824 
  projectmanagers/cmake/cmakeutils.h 8c04c10 
  projectmanagers/cmake/cmakeutils.cpp 3a9c73a 

Diff: http://git.reviewboard.kde.org/r/106156/diff/


Testing
-------

- Build-directory creation, repeated reconfiguration and build (both separately and issuing just "build") while changing global settings. Made sure that existing build directories are handled correctly irrespectively to globally selected builder.
- Pruning created build-directories and repeating steps above. Made sure that new globally selected builder is taken into account on first-time configuration.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120824/760bfb79/attachment.html>