<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106156/">http://git.reviewboard.kde.org/r/106156/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are two TODOs regarding builder selection (ninja vs make vs maybe_eventually_something_else):
- CMakeBuilder::builderForProject()
- CMake::checkForNeedingConfigure()
This adds new code to correctly determine a builder used in project instead of taking some blind assumptions. Also, I've added a configuration key to make it possible to select builder for each build directory (though there is no UI for such setting).
Reason for changes: TODOs and incorrect handling of empty build-directory when Ninja (non-Makefile) is globally selected. If the directory is pruned and then configured through building, it is configured as Ninja, but built with make.
And a question: should we ever attempt to write auto-guessed builder to the config file to "remember" it?
P. S.: the patch-set is provided to make it easier to inspect the changes one by one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Build-directory creation, repeated reconfiguration and build (both separately and issuing just "build") while changing global settings. Made sure that existing build directories are handled correctly irrespectively to globally selected builder.
- Pruning created build-directories and repeating steps above. Made sure that new globally selected builder is taken into account on first-time configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/cmakebuilder/CMakeLists.txt <span style="color: grey">(07807ed)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilder.cpp <span style="color: grey">(b70458d)</span></li>
<li>projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp <span style="color: grey">(63b8e8c)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(e7ab824)</span></li>
<li>projectmanagers/cmake/cmakeutils.h <span style="color: grey">(8c04c10)</span></li>
<li>projectmanagers/cmake/cmakeutils.cpp <span style="color: grey">(3a9c73a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106156/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>