Review Request: Move lockfile remove request dialog (from KDevelop's main()) to kdevplatform.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105917/#review17551
-----------------------------------------------------------


while I applaud the initiative, there are some issues with this approach, esp. with the dbus call (which could be hardcoded while this code was living in kdevelop's sources)


shell/sessioncontroller.h
<http://git.reviewboard.kde.org/r/105917/#comment13770>

    this documentation is lacking, please add some notes on the return type.
    
    i.e. document that if the session @p sessionName is already locked, the user is shown the session picker where he then can select a different session - and that id is then returned by this function



shell/sessioncontroller.h
<http://git.reviewboard.kde.org/r/105917/#comment13768>

    please put the last argument on a new line to break this overly long line



shell/sessioncontroller.cpp
<http://git.reviewboard.kde.org/r/105917/#comment13769>

    again, break line



shell/sessioncontroller.cpp
<http://git.reviewboard.kde.org/r/105917/#comment13771>

    now that this is in kdevplatform, we'll need to figure out what to do with this..
    
    org.kdevelop.kdevelop-... is not correct for anything but the kdevelop app itself. what about quanta? what about ktechlab? if we cannot figure out the name from e.g. QCoreApplication, we might need to extend our ShellExtension class with the required dbus bits and pieces :(


- Milian Wolff


On Aug. 7, 2012, 7:02 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105917/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 7:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Moved the lockfile remove dialog which currently resides in KDevelop's main() - and which is usable only when the session name is explicitly given to the application - to kdevplatform's SessionController.
>     
> This allows to get rid of nasty non-informative error messages about a session being already used
> and replace them with partially refactored code from KDevelop's main() which does the following things:
> 1) Attempts a DBus call to make a running instance visible;
> 2) If it didn't succeed, a dialog window is shown asking permission to force-remove the lockfile or show session chooser dialog;
> 3) If a newly-picked session is also locked, the entire procedure is repeated.
>     
> This code is also used when one picks a session from "Sessions" menu, so a nasty error message has also been removed also from there.
> 
> Related change to KDevelop is here: https://git.reviewboard.kde.org/r/105918/ .
> 
> 
> Diffs
> -----
> 
>   shell/core.cpp 206d48d 
>   shell/sessioncontroller.h 551894d 
>   shell/sessioncontroller.cpp c9fac67 
> 
> Diff: http://git.reviewboard.kde.org/r/105917/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual UI testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120816/4e6df732/attachment.html>