Review Request: Move lockfile remove request dialog (from KDevelop's main()) to kdevplatform.

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105917/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Moved the lockfile remove dialog which currently resides in KDevelop's main() - and which is usable only when the session name is explicitly given to the application - to kdevplatform's SessionController.
    
This allows to get rid of nasty non-informative error messages about a session being already used
and replace them with partially refactored code from KDevelop's main() which does the following things:
1) Attempts a DBus call to make a running instance visible;
2) If it didn't succeed, a dialog window is shown asking permission to force-remove the lockfile or show session chooser dialog;
3) If a newly-picked session is also locked, the entire procedure is repeated.
    
This code is also used when one picks a session from "Sessions" menu, so a nasty error message has also been removed also from there.

Related change to KDevelop is here: https://git.reviewboard.kde.org/r/105918/ .


Diffs
-----

  shell/core.cpp 206d48d 
  shell/sessioncontroller.h 551894d 
  shell/sessioncontroller.cpp c9fac67 

Diff: http://git.reviewboard.kde.org/r/105917/diff/


Testing
-------

Existing unit-tests + manual UI testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120807/bbfe2787/attachment.html>