Change a4fea05a43b8fe57b9f43afeb6ed6bd88601c053, Reduce verbosity while reloading

[Aleix Pol]

On Tue, Aug 14, 2012 at 8:24 AM, Andreas Pakulat <apaku at gmx.de> wrote:
> Hi,
>
> just read my irc backlog and noticed that commit (I'm not reading
> commit mails anymore). I'm wondering about two things:
>
> a) currently it looks like the reload-questions is not shown anymore
> when the document is dirty. That sounds wrong, since it would mean the
> user as unsaved changes and the document is reloaded, so he can loose
> data
It's dirty in the file-system, the flag modified in the IDE is Modified.
Also IDocument::reload is triggered when you call the reload action.

>
> b) Is this really the right way? This function is also called when
> switching between documents, which means that with the change one
> could loose saved changes now by simply switching through tabs or so.
Switching tabs doesn't and shouldn't call IDocument::reload()
I made this patch because it doesn't make sense to me that when we
explicitly reload a file to see what changed in the file system, we
get a dialog asking if we are sure we want that.
Yes, that's why I'm reloading in the first place.

>
> IMHO the silent reload should only be done when the document is not
> dirty and its triggered through reload-all. I had also started a
> discussion to add public API in katepart on kwrite-devel that makes
> this easier, wasn't aware of the modification interface.
>
> Andreas
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

Aleix