Review Request: Parser support for C99 designated initializers

Alexandre Courbot gnurou at gmail.com
Sun Apr 15 07:11:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103448/
-----------------------------------------------------------

(Updated April 15, 2012, 7:11 a.m.)


Review request for KDevelop and Milian Wolff.


Changes
-------

Ok, we should be in business with that one. Some fixes proposed by Ivan have been merged, the call to parseDesignatedInitializer has been moved to parseInitializerList instead of parseInitializerClause (which would uselessly loop from parseInitializerList anyway), making the additional argument unneeded, and the unit tests have been refined to test recursivity and corner-cases. All the noticed issues have been resolved, memory consumption and speed are also normal.


Description
-------

Parser support for C99 designated initializers

Support C99 initializers in the C++ parser, e.g:

struct foo_t foo = {
  .has_cake = true,
  .nb_candles = 12,
};

int bar[10] = {
  [1] = 15,
  [9] = 25,
};


Diffs (updated)
-----

  languages/cpp/parser/parser.h 64b5c505866ac2a0ed847aa67e4c7809df3af6b5 
  languages/cpp/parser/parser.cpp a45ee31a1207d56efef292babb2e774b51378ead 
  languages/cpp/parser/tests/test_parser.h 2869d9ddae2632aced2f2e2fa966382da3a0082d 
  languages/cpp/parser/tests/test_parser.cpp 94e3ee06dc9187568c000dcdd8baf8d87d1d06e6 

Diff: http://git.reviewboard.kde.org/r/103448/diff/


Testing
-------

Used it for a couple of weeks, ensured the parser tests all pass.


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120415/d324c7fc/attachment.html>


More information about the KDevelop-devel mailing list