Review Request: Preprocessor C++11 compliance in number parsing (tokenizer)

[Milian Wolff]

> On April 8, 2012, 5:35 p.m., Milian Wolff wrote:
> > Ship It!

ah btw if you don't have commit rights, please upload this patch as created by "git format-patch" to this review as a "file attachement" (add file in the menu).

thanks


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104508/#review12255
-----------------------------------------------------------


On April 7, 2012, 6:09 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104508/
> -----------------------------------------------------------
> 
> (Updated April 7, 2012, 6:09 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Changed preprocessor numeric value storage to "long long" as per C++11 standard (more precisely, N1988 working draft).
> Implemented parsing of numeric suffixes "LL", "L" and "U" in any combinations and parsing error reporting.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/rpp/pp-engine.h 9128ef1 
>   languages/cpp/parser/rpp/pp-engine.cpp 71f7f21 
>   languages/cpp/parser/tests/test_parser.cpp 3a4c7b9 
> 
> Diff: http://git.reviewboard.kde.org/r/104508/diff/
> 
> 
> Testing
> -------
> 
> Unit-tests added regarding new suffixes, error reporting/detection and internal storage limits check.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120408/417b2d07/attachment.html>