Review Request: "noexcept" keyword parsing

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104498/#review12224
-----------------------------------------------------------


this is missing unit tests, I'll work on this now though if you don't have time. please contact me on irc if you are there though (#kdevelop on freenode, I'm called milian)

- Milian Wolff


On April 6, 2012, 5:35 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104498/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 5:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Adds initial parser support for "noexcept" and "noexcept(...)" declaration specifiers in KDevelop C++ parser.
> This is particularly useful with new GCC toolchain version 4.7.0, where these keywords are frequently used throughout STL.
> 
> 
> This addresses bug 297604.
>     http://bugs.kde.org/show_bug.cgi?id=297604
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/ast.h 46ecac7c4f652e556b83188b08db50fe3b2d7b78 
>   languages/cpp/parser/codegenerator.cpp 962fe5be3d82fe785e74a5a896ff207c25cff789 
>   languages/cpp/parser/default_visitor.cpp 174e5d98f7efd7bebb3508c2bc9bd855e4e5e810 
>   languages/cpp/parser/lexer.cpp 0cdad1e9549ef413351a1e102a3b14e00e2c4f86 
>   languages/cpp/parser/parser.cpp 50c09a88b3c69a173477e4a4cf06ae566daf3b64 
>   languages/cpp/parser/tokens.h 3e73330c649032503a20137231d479ec2225733c 
>   languages/cpp/parser/tokens.cpp 3d8c05fba9e02b1dc57dd17ae1f33ae581b06cdb 
> 
> Diff: http://git.reviewboard.kde.org/r/104498/diff/
> 
> 
> Testing
> -------
> 
> A test file with intensive STL usage is uploaded.
> 
> Steps to reproduce:
> 1) Open the test file in KDevelop 4.3.60 compiled from branch 'master' (commit 8c73677)
> See that "std::pair<>" is resolved as function with no return type; "std::map<>" and "std::vector<>" are not highlighted at all.
> 
> 2) Apply patches, rebuild KDevelop and clear your current DUChain cache
> # rm -rf ~/.kdevduchain
> 
> 3) Reopen the test file
> See that all STL typedefs and method calls are parsed and highlighted correctly.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120407/03473c13/attachment.html>