Review Request: Fix modified status at file opening when using trailing spaces cleanup

Milian Wolff mail at milianw.de
Wed Apr 4 11:24:59 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104429/#review12159
-----------------------------------------------------------

Ship it!


no idea what it does, but I trust you in this one if it helps with the bug :)

- Milian Wolff


On March 27, 2012, 8:50 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104429/
> -----------------------------------------------------------
> 
> (Updated March 27, 2012, 8:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When the katepart's "Remove trailing spaces" option was active and the opened file was cleaned up at opening kdevelop was not noticing it.
> 
> 
> Diffs
> -----
> 
>   shell/textdocument.cpp ec79dec 
> 
> Diff: http://git.reviewboard.kde.org/r/104429/diff/
> 
> 
> Testing
> -------
> 
> - Open a file containing lines requiring cleanup
> - Check if the file view is correctly updated (no spaces)
> - Check the tab (modified icon appears in the filetab) indicating that kdevelop noticed the changes
> - Press Ctrl+Z (undo) : the spaces reappear and the modified flag goes away
> - Press Ctrl+Shift+Z (redo) : reupdates both the file and the modified flag
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120404/edfcfdd2/attachment.html>


More information about the KDevelop-devel mailing list