Review Request: Speed up collapsing of all elements in Find/Replace treeview.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102894/#review7383
-----------------------------------------------------------

Ship it!


yeah sounds fine, please fix the two small codestyle issues and then commit or send the patch as created by "git format-patch".

thanks


plugins/grepview/grepoutputview.cpp
<http://git.reviewboard.kde.org/r/102894/#comment6451>

    make it: const QModelIndex



plugins/grepview/grepoutputview.cpp
<http://git.reviewboard.kde.org/r/102894/#comment6450>

    please wrap in {}:
    
    for() {
      ...
    }


- Milian Wolff


On Oct. 16, 2011, 11:20 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102894/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2011, 11:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Small patch that really speeds up the collapse all in find/replace treeview, it is not very pretty but it seems to work well, and whithout flicker.
> Here are some bench I made :
> * Search for "kate" in kdevplatform, not sensitive, 188 matches in 134 files :
>   - Old method : 7657 ms to collapse all
>   - New method : 38 ms
> 
> * Search for "model" in kdevplatform, not sensitive, 6475 matches in 336 files :
>   - Old method : 56339 ms to collapse all
>   - New method : 94 ms
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepoutputview.cpp dc0a555 
> 
> Diff: http://git.reviewboard.kde.org/r/102894/diff/diff
> 
> 
> Testing
> -------
> 
> Search for all kind of stuff, try to expand/collapse all, search for non existing elements (in that case, the buttons are not sensitive).
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111016/984b6752/attachment.html>