Review Request: Speed up collapsing of all elements in Find/Replace treeview.
Lambert CLARA
lambert.clara at yahoo.fr
Sun Oct 16 11:20:23 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102894/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
Small patch that really speeds up the collapse all in find/replace treeview, it is not very pretty but it seems to work well, and whithout flicker.
Here are some bench I made :
* Search for "kate" in kdevplatform, not sensitive, 188 matches in 134 files :
- Old method : 7657 ms to collapse all
- New method : 38 ms
* Search for "model" in kdevplatform, not sensitive, 6475 matches in 336 files :
- Old method : 56339 ms to collapse all
- New method : 94 ms
Diffs
-----
plugins/grepview/grepoutputview.cpp dc0a555
Diff: http://git.reviewboard.kde.org/r/102894/diff/diff
Testing
-------
Search for all kind of stuff, try to expand/collapse all, search for non existing elements (in that case, the buttons are not sensitive).
Thanks,
Lambert CLARA
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111016/8513df88/attachment.html>
More information about the KDevelop-devel
mailing list