Review Request: allow spaces in path in warnings

Bernd Buschinski b.buschinski at web.de
Fri Oct 14 11:49:46 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102860/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

This patch Fixes Bug 283722.

KDevelop is currently not abled to handle spaces in paths when showing warning in buildsubwindow.
The RegExp in outputfilters.cpp:19 does not allow spaces in path.
So for a path like "/a b c/test/main.cpp", it returns something like "c/test/main.cpp" which is just wrong. And is unabled to open the correct file.

NOTE: Since gcc-4.5 warnings are shown with coulmn by default, which triggers the regexp in line 19.
Older gcc, and gcc-4.5+ with -fno-show-column trigger regexp in line 21, which also disallows spaces in path.


This addresses bug 283722.
    http://bugs.kde.org/show_bug.cgi?id=283722


Diffs
-----

  projectbuilders/makebuilder/outputfilters.cpp 50fe0db 

Diff: http://git.reviewboard.kde.org/r/102860/diff/diff


Testing
-------

Tested with common warnings like 
"/home/buscher/master2/Graphisch interaktive Systeme/Praktikum/pawbus/src/scheckerspawn.cpp:37:9: warning: unused variable 'i' [-Wunused-variable]"

and with -fno-show-column
"/home/buscher/master2/Graphisch interaktive Systeme/Praktikum/pawbus/src/scheckerspawn.cpp:37: warning: unused variable 'i' [-Wunused-variable]"


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/e55d6263/attachment.html>


More information about the KDevelop-devel mailing list