<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102860/">http://git.reviewboard.kde.org/r/102860/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Bernd Buschinski.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch Fixes Bug 283722.
KDevelop is currently not abled to handle spaces in paths when showing warning in buildsubwindow.
The RegExp in outputfilters.cpp:19 does not allow spaces in path.
So for a path like "/a b c/test/main.cpp", it returns something like "c/test/main.cpp" which is just wrong. And is unabled to open the correct file.
NOTE: Since gcc-4.5 warnings are shown with coulmn by default, which triggers the regexp in line 19.
Older gcc, and gcc-4.5+ with -fno-show-column trigger regexp in line 21, which also disallows spaces in path.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with common warnings like
"/home/buscher/master2/Graphisch interaktive Systeme/Praktikum/pawbus/src/scheckerspawn.cpp:37:9: warning: unused variable 'i' [-Wunused-variable]"
and with -fno-show-column
"/home/buscher/master2/Graphisch interaktive Systeme/Praktikum/pawbus/src/scheckerspawn.cpp:37: warning: unused variable 'i' [-Wunused-variable]"</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283722">283722</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/makebuilder/outputfilters.cpp <span style="color: grey">(50fe0db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102860/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>