Review Request: Better error handling in the BranchManager dialog

[Sergey Vidyuk]

> On Oct. 14, 2011, 10:14 a.m., Milian Wolff wrote:
> > vcs/dvcs/ui/branchmanager.cpp, line 78
> > <http://git.reviewboard.kde.org/r/102850/diff/1/?file=38831#file38831line78>
> >
> >     please make this error message a bit more verbose, i.e.:
> >     
> >     You must select a base branch in toolview XYZ before creating a new branch.
> >     
> >     Also: the button that triggers the call to createBranch should be disabled when no base branch was selected - i.e. this error should be prevented.

Right now this situation should not happen since this dialog is not shown if current branch can't be determined and current branch is current element by default. However it might change in future. For example right now it's impossible to switch branch in a project in detached head state from kdevelop UI due to this behaviour.

Disabling create button until base branch is selected might be confusing. It looks quite strange when create button is disabled until at least anything is selected. As a user I would prefere dialog saying what is wrong.

Actually this dialog is already a bit cunfising. Before looking through the code I thought that new branch base will be current HEAD state. Maybe it would be better to move create new branch action into context menu for branches from the list (similair to the gitk behaviour). What dou you think about it?


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102850/#review7318
-----------------------------------------------------------


On Oct. 14, 2011, 8:35 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102850/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 8:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
>  * Correct handling of cancel on enter new branch name dialog.
>  * Handling situation when current index is not set in the branches list.
>  * Set current index in the branches list in constructor.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/ui/branchmanager.cpp 7de4776 
> 
> Diff: http://git.reviewboard.kde.org/r/102850/diff/diff
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/730ff2d0/attachment.html>