Review Request: Better error handling in the BranchManager dialog

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102850/#review7318
-----------------------------------------------------------



vcs/dvcs/ui/branchmanager.cpp
<http://git.reviewboard.kde.org/r/102850/#comment6392>

    was it not enough to only setCurrentIndex? i.e. is that not updating the selection?
    
    if not, make sure that the view has the proper selectionmode set (i.e. SelectRows or how that was called). Imo the selectionModel call is superflous



vcs/dvcs/ui/branchmanager.cpp
<http://git.reviewboard.kde.org/r/102850/#comment6393>

    please make this error message a bit more verbose, i.e.:
    
    You must select a base branch in toolview XYZ before creating a new branch.
    
    Also: the button that triggers the call to createBranch should be disabled when no base branch was selected - i.e. this error should be prevented.


- Milian Wolff


On Oct. 14, 2011, 8:35 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102850/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 8:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
>  * Correct handling of cancel on enter new branch name dialog.
>  * Handling situation when current index is not set in the branches list.
>  * Set current index in the branches list in constructor.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/ui/branchmanager.cpp 7de4776 
> 
> Diff: http://git.reviewboard.kde.org/r/102850/diff/diff
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/71b3f02f/attachment.html>