Review Request: Properly Connect Protocol Config Widget in KDE Provider

David Narváez david.narvaez at computer.org
Sat Nov 19 14:12:33 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103185/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Changing the name of the widget allows it to connect to the gitProtocol configuration setting. Also added the kcfg_property property to avoid issues with the QComboBox value.


Diffs
-----

  providers/kdeprovider/kdeconfig.ui c3f17a7 
  providers/kdeprovider/kdeproviderwidget.cpp 3467afb 

Diff: http://git.reviewboard.kde.org/r/103185/diff/diff


Testing
-------

1. Open/Fetch Project...
2. Select the KDE Provider
3. Click on the Settings button next to the Project selection Combo Box
4. Switch to HTTP or SSH
5. Fetch the project

Before this patch, the fetching URL would always be http://anongit.kde.org (default for git protocol). This patch enables fetching from http and ssh too.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111119/07449fcc/attachment.html>


More information about the KDevelop-devel mailing list