Review Request: UI improvements for the project build docker

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103115/#review8205
-----------------------------------------------------------


Sorry but this is wrong:

- There's no need for a proxy model at all, simply do it in the source model
- If a proxy is used all places using itemview or selection model indices need to be adjusted to map from source to proxy and vice versa
- QProxyModel is obsolete and should not be used in new code

In addition I think this is no improvement at all. If there are two main.cpp files I'd need to hover over each to find out where in the project
they are located instead of being able to instantly see it.

- Andreas Pakulat


On Nov. 12, 2011, 8:14 a.m., Carlos Licea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103115/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2011, 8:14 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I removed some clutter by removing the path and showing it on a tooltip. I also removed the top header.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 7b58e8e 
>   plugins/projectmanagerview/projectbuildsetproxymodel.h PRE-CREATION 
>   plugins/projectmanagerview/projectbuildsetproxymodel.cpp PRE-CREATION 
>   plugins/projectmanagerview/projectbuildsetwidget.cpp 585a1c8 
>   plugins/projectmanagerview/projectbuildsetwidget.ui 90e74e1 
> 
> Diff: http://git.reviewboard.kde.org/r/103115/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carlos Licea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111115/b6cd6076/attachment.html>