<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103115/">http://git.reviewboard.kde.org/r/103115/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry but this is wrong:
- There's no need for a proxy model at all, simply do it in the source model
- If a proxy is used all places using itemview or selection model indices need to be adjusted to map from source to proxy and vice versa
- QProxyModel is obsolete and should not be used in new code
In addition I think this is no improvement at all. If there are two main.cpp files I'd need to hover over each to find out where in the project
they are located instead of being able to instantly see it.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On November 12th, 2011, 8:14 a.m., Carlos Licea wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Carlos Licea.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2011, 8:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I removed some clutter by removing the path and showing it on a tooltip. I also removed the top header.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(7b58e8e)</span></li>
<li>plugins/projectmanagerview/projectbuildsetproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projectbuildsetproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projectbuildsetwidget.cpp <span style="color: grey">(585a1c8)</span></li>
<li>plugins/projectmanagerview/projectbuildsetwidget.ui <span style="color: grey">(90e74e1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>