Review Request: Fix compile break of quanta

Florian Zumkeller-Quast branleb at googlemail.com
Thu Nov 10 15:42:26 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/
-----------------------------------------------------------

(Updated Nov. 10, 2011, 3:42 p.m.)


Review request for KDevelop and Quanta.


Changes
-------

The patch created by git format-patch. I fixed the style issues.


Description
-------

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.


Diffs
-----

  languages/xml/formatter/formatterplugin.h e8799f1 
  languages/xml/formatter/formatterplugin.cpp 4b04725 
  languages/xml/formatter/sgmlformatter.cpp 4a99d79 
  languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f 
  plugins/phpformatter/formatterplugin.h 8b462bc 
  plugins/phpformatter/formatterplugin.cpp 761d635 

Diff: http://git.reviewboard.kde.org/r/103106/diff/diff


Testing
-------

Quanta compiles fine with that patch.


Thanks,

Florian Zumkeller-Quast

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111110/54edaed5/attachment.html>


More information about the KDevelop-devel mailing list