Review Request: Enhance QtHelp context menu

Valentyn Pavliuchenko valentyn.pavliuchenko at gmail.com
Thu Nov 10 16:08:59 UTC 2011



> On Nov. 9, 2011, 11:28 p.m., Aleix Pol Gonzalez wrote:
> > Looks good to me. Maybe you can set the edit-copy icon to the copy action?
> > 
> > Other than that it can get in. Do you have an account?
> 
> Valentyn Pavliuchenko wrote:
>     I'll look what I can do regarding the icon (both CMake and Manpage doesn't have it, so I think I'll do a separate merge request for that).
>     
>     I don't have an account, so please push it.
> 
> Aleix Pol Gonzalez wrote:
>     Can you send me a patch with "git format-patch"? Thanks!

Will do that today.


- Valentyn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103102/#review8073
-----------------------------------------------------------


On Nov. 9, 2011, 11:10 p.m., Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103102/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 11:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> 1. Added "Copy" to context menu - allows copying code examples (CMake and Manpage docs already have it)
> 2. Use radiobuttons instead of key list - makes menu more understandable.
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpdocumentation.h bb6c202 
>   documentation/qthelp/qthelpdocumentation.cpp d2e0c19 
> 
> Diff: http://git.reviewboard.kde.org/r/103102/diff/diff
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Screenshots
> -----------
> 
> New context menu
>   http://git.reviewboard.kde.org/r/103102/s/334/
> 
> 
> Thanks,
> 
> Valentyn Pavliuchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111110/46d28178/attachment.html>


More information about the KDevelop-devel mailing list