Review Request: Enhance QtHelp context menu

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103102/#review8101
-----------------------------------------------------------


just a few style nitpicks and ideas for future work - the patch is good otherwise.

if you cannot commit yourself, please provide this patch as created by "git format-patch" with the issues below fixed.

thanks


documentation/qthelp/qthelpdocumentation.cpp
<http://git.reviewboard.kde.org/r/103102/#comment6968>

    please remove the this->



documentation/qthelp/qthelpdocumentation.cpp
<http://git.reviewboard.kde.org/r/103102/#comment6969>

    could you try out whether the following actions (and maybe others) are useful as well:
    
    QWebPage::Back
    QWebPage::Forward



documentation/qthelp/qthelpdocumentation.cpp
<http://git.reviewboard.kde.org/r/103102/#comment6967>

    as a further improvement (second patch?), please hide this if m_info.size() == 1.
    
    if you look at your screenshot, that action is pretty useless in such a case.


- Milian Wolff


On Nov. 9, 2011, 11:10 p.m., Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103102/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 11:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> 1. Added "Copy" to context menu - allows copying code examples (CMake and Manpage docs already have it)
> 2. Use radiobuttons instead of key list - makes menu more understandable.
> 
> 
> Diffs
> -----
> 
>   documentation/qthelp/qthelpdocumentation.h bb6c202 
>   documentation/qthelp/qthelpdocumentation.cpp d2e0c19 
> 
> Diff: http://git.reviewboard.kde.org/r/103102/diff/diff
> 
> 
> Testing
> -------
> 
> Manual.
> 
> 
> Screenshots
> -----------
> 
> New context menu
>   http://git.reviewboard.kde.org/r/103102/s/334/
> 
> 
> Thanks,
> 
> Valentyn Pavliuchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111110/791da2ca/attachment.html>