Review Request: Fix compile break of quanta

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/#review8100
-----------------------------------------------------------

Ship it!


commit is fine besides a few style issues, put the &,* always adjacent to the typename for consistency please.

if you have commit rights, please fix this before pushing.

otherwise send me this patch as created by "git format-patch" - if possible with the style issue fixed. otherwise I'll do that.

thanks 


languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6962>

    please put the & adjacent to the typename for consistency



languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6963>

    also here, & adjacent to the typename please



plugins/phpformatter/formatterplugin.h
<http://git.reviewboard.kde.org/r/103106/#comment6964>

    again, please & adjacent to typename



plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6965>

    & again... :)



plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6966>

    & again... :)


- Milian Wolff


On Nov. 10, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103106/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2011, 12:05 p.m.)
> 
> 
> Review request for KDevelop and Quanta.
> 
> 
> Description
> -------
> 
> Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta.
> This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.
> 
> 
> Diffs
> -----
> 
>   languages/xml/formatter/formatterplugin.h e8799f1 
>   languages/xml/formatter/formatterplugin.cpp 4b04725 
>   languages/xml/formatter/sgmlformatter.cpp 4a99d79 
>   languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f 
>   plugins/phpformatter/formatterplugin.h 8b462bc 
>   plugins/phpformatter/formatterplugin.cpp 761d635 
> 
> Diff: http://git.reviewboard.kde.org/r/103106/diff/diff
> 
> 
> Testing
> -------
> 
> Quanta compiles fine with that patch.
> 
> 
> Thanks,
> 
> Florian Zumkeller-Quast
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111110/f138492c/attachment.html>