Review Request: Replacing QPointer with QWeakPointer

Glen Kaukola gkaukola at cs.ucr.edu
Tue May 24 20:28:21 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101420/
-----------------------------------------------------------

(Updated May 24, 2011, 8:28 p.m.)


Review request for KDevelop.


Changes
-------

Updated the diff with Aleix's suggestions.


Summary
-------

Replaced a number off occurrences of QPointer with QWeakPointer.


This addresses bug 260586.
    http://bugs.kde.org/show_bug.cgi?id=260586


Diffs (updated)
-----

  debugger/variable/variablecollection.h ca7546c 
  util/activetooltip.cpp 3d14f77 
  vcs/widgets/vcsdiffpatchsources.h ca74323 
  vcs/widgets/vcsdiffpatchsources.cpp 7b67c97 

Diff: http://git.reviewboard.kde.org/r/101420/diff


Testing
-------

Compiled and installed kdevplatform.  Compiled kdevelop.  Ran kdevelop and verified popups still come up when hovering over variable names.  Still not sure if that's what variabletooltip.cpp is doing however.


Thanks,

Glen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110524/c9d70af6/attachment.html>


More information about the KDevelop-devel mailing list