Review Request: Replacing QPointer with QWeakPointer

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101420/#review3463
-----------------------------------------------------------



debugger/variable/variablecollection.cpp
<http://git.reviewboard.kde.org/r/101420/#comment2912>

    Not necessary, the QWeakPointer implements the bool operator.



util/activetooltip.cpp
<http://git.reviewboard.kde.org/r/101420/#comment2913>

    Same here



vcs/widgets/vcsdiffpatchsources.cpp
<http://git.reviewboard.kde.org/r/101420/#comment2914>

    and here



vcs/widgets/vcsdiffpatchsources.cpp
<http://git.reviewboard.kde.org/r/101420/#comment2915>

    and here


- Aleix


On May 22, 2011, 10:16 p.m., Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101420/
> -----------------------------------------------------------
> 
> (Updated May 22, 2011, 10:16 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Replaced a number off occurrences of QPointer with QWeakPointer.
> 
> 
> This addresses bug 260586.
>     http://bugs.kde.org/show_bug.cgi?id=260586
> 
> 
> Diffs
> -----
> 
>   debugger/variable/variablecollection.h ca7546c 
>   debugger/variable/variablecollection.cpp ac084e3 
>   util/activetooltip.cpp 3d14f77 
>   vcs/widgets/vcsdiffpatchsources.h ca74323 
>   vcs/widgets/vcsdiffpatchsources.cpp 7b67c97 
> 
> Diff: http://git.reviewboard.kde.org/r/101420/diff
> 
> 
> Testing
> -------
> 
> Compiled and installed kdevplatform.  Compiled kdevelop.  Ran kdevelop and verified popups still come up when hovering over variable names.  Still not sure if that's what variabletooltip.cpp is doing however.
> 
> 
> Thanks,
> 
> Glen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110523/bb7860d3/attachment.html>