Review Request: Save/restore ProjectManagerView filter to/from session's config

Eugene Agafonov e.a.agafonov at gmail.com
Mon May 23 18:46:42 UTC 2011



> On May 23, 2011, 2:15 p.m., Aleix Pol Gonzalez wrote:
> > Why do you store the initial filter? you're not using it anymore...

Did catch actually...

ProjectManagerFilterAction::m_initialFilter is set upon action creation on projectmanagerview.cpp:152 and later is it used to initilize KLineEdit when ProjectManagerFilterAction::createWidget is called.
ProjectManagerFilterAction::createWidget calls KLineEdit::setText(m_intialFilter) which emits filterChanged() so ProjectManagerView::filterChanged() is intially called in turn.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101426/#review3465
-----------------------------------------------------------


On May 23, 2011, 10:59 a.m., Eugene Agafonov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101426/
> -----------------------------------------------------------
> 
> (Updated May 23, 2011, 10:59 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Here is yet another enhancement for ProjectManagerView filter.
> 
> Filter string is now saved in session's config when PMV is closed (and restored upon PMV creation)
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 6d3ac0e 
>   plugins/projectmanagerview/projectmanagerview.cpp 13b24ed 
> 
> Diff: http://git.reviewboard.kde.org/r/101426/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eugene
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110523/a6e719ff/attachment.html>


More information about the KDevelop-devel mailing list