<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101426/">http://git.reviewboard.kde.org/r/101426/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 23rd, 2011, 2:15 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do you store the initial filter? you're not using it anymore...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did catch actually...
ProjectManagerFilterAction::m_initialFilter is set upon action creation on projectmanagerview.cpp:152 and later is it used to initilize KLineEdit when ProjectManagerFilterAction::createWidget is called.
ProjectManagerFilterAction::createWidget calls KLineEdit::setText(m_intialFilter) which emits filterChanged() so ProjectManagerView::filterChanged() is intially called in turn.</pre>
<br />
<p>- Eugene</p>
<br />
<p>On May 23rd, 2011, 10:59 a.m., Eugene Agafonov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Eugene Agafonov.</div>
<p style="color: grey;"><i>Updated May 23, 2011, 10:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is yet another enhancement for ProjectManagerView filter.
Filter string is now saved in session's config when PMV is closed (and restored upon PMV creation)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/projectmanagerview.h <span style="color: grey">(6d3ac0e)</span></li>
<li>plugins/projectmanagerview/projectmanagerview.cpp <span style="color: grey">(13b24ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>