Review Request: Allow to mark Declaration instances as "automatically created"

David Nolden david.nolden.kde at art-master.de
Sat Mar 26 18:00:10 UTC 2011



> On March 25, 2011, 1:21 p.m., Sven Brauch wrote:
> > Apparently, there's no emails sent when using the "comment" button...
> > So again, I mistakenly used && instead of || in the previous patch, which screws up stuff. Okay to push a fix?
> > 
> > Cheers,
> > Sven

Of course you can push the fix right away, just make sure it's right. :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100936/#review2169
-----------------------------------------------------------


On March 24, 2011, 2:04 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100936/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 2:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Allow to mark Declaration instances as "automatically created", so they aren't automatically deleted if they weren't encountered while the context containing them was generated. This is useful for languages like python and php, where you can do something like "foo = A(); foo.x=3" without having defined a property named x in the class A previously.
> I'm not sure about the change in ducontext.cpp; maybe that will be too slow, I don't know.
> 
> 
> Diffs
> -----
> 
>   language/duchain/declaration.h 92e0c62 
>   language/duchain/declaration.cpp b46e4f1 
>   language/duchain/declarationdata.h 3ae64ba 
>   language/duchain/ducontext.h 9e7b75b 
>   language/duchain/ducontext.cpp 3ec527b 
>   language/duchain/repositories/itemrepository.cpp c76befd 
>   language/duchain/uses.h 7f9b90a 
>   language/duchain/uses.cpp d1fedee 
> 
> Diff: http://git.reviewboard.kde.org/r/100936/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110326/17acdf20/attachment.html>


More information about the KDevelop-devel mailing list