<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100936/">http://git.reviewboard.kde.org/r/100936/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2011, 1:21 p.m., <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently, there's no emails sent when using the "comment" button...
So again, I mistakenly used && instead of || in the previous patch, which screws up stuff. Okay to push a fix?
Cheers,
Sven</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course you can push the fix right away, just make sure it's right. :)</pre>
<br />
<p>- David</p>
<br />
<p>On March 24th, 2011, 2:04 a.m., Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated March 24, 2011, 2:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow to mark Declaration instances as "automatically created", so they aren't automatically deleted if they weren't encountered while the context containing them was generated. This is useful for languages like python and php, where you can do something like "foo = A(); foo.x=3" without having defined a property named x in the class A previously.
I'm not sure about the change in ducontext.cpp; maybe that will be too slow, I don't know.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/duchain/declaration.h <span style="color: grey">(92e0c62)</span></li>
<li>language/duchain/declaration.cpp <span style="color: grey">(b46e4f1)</span></li>
<li>language/duchain/declarationdata.h <span style="color: grey">(3ae64ba)</span></li>
<li>language/duchain/ducontext.h <span style="color: grey">(9e7b75b)</span></li>
<li>language/duchain/ducontext.cpp <span style="color: grey">(3ec527b)</span></li>
<li>language/duchain/repositories/itemrepository.cpp <span style="color: grey">(c76befd)</span></li>
<li>language/duchain/uses.h <span style="color: grey">(7f9b90a)</span></li>
<li>language/duchain/uses.cpp <span style="color: grey">(d1fedee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100936/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>