Review Request: Ask the user whether to clean DUChain repository after multiple crashes.

[Dmitry Risenberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100822/
-----------------------------------------------------------

(Updated March 8, 2011, 10:52 p.m.)


Review request for KDevelop.


Changes
-------

Clarified the dialog message and switched to OK/Cancel buttons.

As for utility of this for the user - even if they decide to clear the repository, they won't wonder why parsing takes so long after it. Besides, KDevelop could just be closed incorrectly without decreasing the counter.


Summary
-------

Got bitten by the code in ItemRepositoryRegistry::open a few times while debugging, when my repository was cleaned and total reparsing was made. The patch adds a message box which allows the user to choose between cleaning the repository and leaving it as is.

The bigger question - is this code still useful? I haven't experienced any DUChain-related crashes, while crashes for other reasons still happen. So the user might get a full reparsing if some other part of KDevelop misbehaves.


Diffs (updated)
-----

  language/duchain/repositories/itemrepository.cpp e603b222330faf994525837e8d0d3c3931dd61c4 

Diff: http://git.reviewboard.kde.org/r/100822/diff


Testing
-------


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/ee6f1178/attachment.html>