Review Request: Ask the user whether to clean DUChain repository after multiple crashes.

[David Nolden]

> On March 8, 2011, 3:53 p.m., Milian Wolff wrote:
> > while personally I might have use for this dialog, I think it's not good for end users.
> > 
> > Any crash of kdevelop might screw up the internal duchain state and lead to random crashes (yes, that happens very often).
> > Wiping the cache is the only solution here and hence it should stay. Maybe make this configurable (hidden option without UI) so developers can enable this.
> > 
> > bye
> 
> David Nolden wrote:
>     But the good thing about the dialog is that it gives the user a hint of what's going on. It looks a bit odd when the application crashes 3 times in a row and then suddenly it works again without an obvious reason.
> 
> Sven Brauch wrote:
>     I like the idea. Still, I guess a typical user will not have any idea what that message means, tough. If I as a user was asked weather i want to delete something I've never hear of, I'd click "No" for sure (which is not the safe answer here).

That's why it rather should be OK/Cancel, see the comment below, with "OK=Delete". Maybe we should also say that we're just deleting a "Cache", not a "Repository".


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100822/#review1847
-----------------------------------------------------------


On March 8, 2011, 2:25 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100822/
> -----------------------------------------------------------
> 
> (Updated March 8, 2011, 2:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Got bitten by the code in ItemRepositoryRegistry::open a few times while debugging, when my repository was cleaned and total reparsing was made. The patch adds a message box which allows the user to choose between cleaning the repository and leaving it as is.
> 
> The bigger question - is this code still useful? I haven't experienced any DUChain-related crashes, while crashes for other reasons still happen. So the user might get a full reparsing if some other part of KDevelop misbehaves.
> 
> 
> Diffs
> -----
> 
>   language/duchain/repositories/itemrepository.cpp e603b222330faf994525837e8d0d3c3931dd61c4 
> 
> Diff: http://git.reviewboard.kde.org/r/100822/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/e2c4d6e3/attachment.html>