Review Request: Ask the user whether to clean DUChain repository after multiple crashes.

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100822/#review1846
-----------------------------------------------------------

Ship it!


Looks good (please see the comment).

I think we should keep this. If the repository should ever get corrupted in some way, the user will be able to clear it without having to ask us how to do it. It is true that other crashes are much much more frequent though.


language/duchain/repositories/itemrepository.cpp
<http://git.reviewboard.kde.org/r/100822/#comment1511>

    A description that is more understandable to the user would be better. Something like: "The application has crashed %1 times in a row. The crashes might result from a corruped code-analysis repository. Do you want to clear the repository?"


- David


On March 8, 2011, 2:25 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100822/
> -----------------------------------------------------------
> 
> (Updated March 8, 2011, 2:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Got bitten by the code in ItemRepositoryRegistry::open a few times while debugging, when my repository was cleaned and total reparsing was made. The patch adds a message box which allows the user to choose between cleaning the repository and leaving it as is.
> 
> The bigger question - is this code still useful? I haven't experienced any DUChain-related crashes, while crashes for other reasons still happen. So the user might get a full reparsing if some other part of KDevelop misbehaves.
> 
> 
> Diffs
> -----
> 
>   language/duchain/repositories/itemrepository.cpp e603b222330faf994525837e8d0d3c3931dd61c4 
> 
> Diff: http://git.reviewboard.kde.org/r/100822/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/73cd87ff/attachment.html>