Review Request: Add options to StandardOutputView plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100666/#review1762
-----------------------------------------------------------

Ship it!


as said on irc, I've fixed the unit test and it is now mergable, but please squash the commits so that all those "remove it, bring it back, remove it" hick hack is gone ;-)

- Milian


On March 4, 2011, 12:39 p.m., Silvère Lestang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100666/
> -----------------------------------------------------------
> 
> (Updated March 4, 2011, 12:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add to StandardOutputView plugin:
>  * An option to display or not the two buttons "Select activated Item" and "Focus when selecting Item"
>  * An optional filter action, added to "build", "run" and "debug" outputview
>  * the possibility to add a list of QAction to an outputview (the actions appears in the toolbar and the context menu)
> 
> Fix: now when we remove an output view from one Area, it's removed from all Areas
> 
> Know bug: If you remove quickly many outputs displayed in more than one Area, KDevelop crash. I can't fix the bug as I don't know where and why it's appears exactly (if I attached the debugger, KDevelop is slower so making the bug disappear).
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/outputwidget.cpp 18e35e7 
>   plugins/standardoutputview/CMakeLists.txt bdb23e4 
>   plugins/standardoutputview/kdevstandardoutputview.rc 5455135 
>   plugins/standardoutputview/outputwidget.h eef3844 
>   plugins/standardoutputview/standardoutputview.h 4f7e1bf 
>   plugins/standardoutputview/standardoutputview.cpp fbdae75 
>   plugins/standardoutputview/tests/CMakeLists.txt PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.h PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp PRE-CREATION 
>   plugins/standardoutputview/toolviewdata.h 14afd45 
> 
> Diff: http://git.reviewboard.kde.org/r/100666/diff
> 
> 
> Testing
> -------
> 
> A test has been adding for the plugin - it's pass - but it's reimplement the macro QTEST_KDEMAIN to get round a bug that I don't understand.
> 
> 
> Thanks,
> 
> Silvère
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110304/e42be347/attachment.html>