<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100666/">http://git.reviewboard.kde.org/r/100666/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as said on irc, I've fixed the unit test and it is now mergable, but please squash the commits so that all those "remove it, bring it back, remove it" hick hack is gone ;-)</pre>
<br />
<p>- Milian</p>
<br />
<p>On March 4th, 2011, 12:39 p.m., Silvère Lestang wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Silvère Lestang.</div>
<p style="color: grey;"><i>Updated March 4, 2011, 12:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add to StandardOutputView plugin:
* An option to display or not the two buttons "Select activated Item" and "Focus when selecting Item"
* An optional filter action, added to "build", "run" and "debug" outputview
* the possibility to add a list of QAction to an outputview (the actions appears in the toolbar and the context menu)
Fix: now when we remove an output view from one Area, it's removed from all Areas
Know bug: If you remove quickly many outputs displayed in more than one Area, KDevelop crash. I can't fix the bug as I don't know where and why it's appears exactly (if I attached the debugger, KDevelop is slower so making the bug disappear).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A test has been adding for the plugin - it's pass - but it's reimplement the macro QTEST_KDEMAIN to get round a bug that I don't understand.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/standardoutputview/outputwidget.cpp <span style="color: grey">(18e35e7)</span></li>
<li>plugins/standardoutputview/CMakeLists.txt <span style="color: grey">(bdb23e4)</span></li>
<li>plugins/standardoutputview/kdevstandardoutputview.rc <span style="color: grey">(5455135)</span></li>
<li>plugins/standardoutputview/outputwidget.h <span style="color: grey">(eef3844)</span></li>
<li>plugins/standardoutputview/standardoutputview.h <span style="color: grey">(4f7e1bf)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(fbdae75)</span></li>
<li>plugins/standardoutputview/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/standardoutputview/tests/standardoutputviewtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/standardoutputview/tests/standardoutputviewtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/standardoutputview/toolviewdata.h <span style="color: grey">(14afd45)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>