Review Request: Make "No matching function call" candidates clickable in build output

[Manuel Massing]

> On Feb. 24, 2011, 11:31 p.m., Aleix Pol Gonzalez wrote:
> > projectbuilders/makebuilder/makeoutputmodel.h, line 41
> > <http://git.reviewboard.kde.org/r/100738/diff/1/?file=10087#file10087line41>
> >
> >     Why did you change the order of the enumerees?

I just wanted to make the relation to WarningItem/ErrorItem clear by grouping them.
(I think the specific numbering scheme is of no interest outside of MakeOutputModel and MakeOutputView, 
so I am not sure why it would make sense to keep an explicit numbering at all?)

Anyway, the whole "InformationItem" part is optional, we could just handle the "note" the same way
as a warning, but I thought in the future one might want to change the layout/behaviour of 
this class of compiler messages. 

I can also submit a simplified patch without the InformationItem stuff if you prefer.


- Manuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100738/#review1637
-----------------------------------------------------------


On Feb. 24, 2011, 11:01 p.m., Manuel Massing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100738/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2011, 11:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When gcc encounters a non-matching function call, it spits out a 
> list of candidate methods. This patch makes the lines with candidate methods 
> clickable, so one can jump to the declaration.
> 
> The patch also introduces a differentiation between informative/warning
> messages, which is not really necessary for this patch, but might prove useful
> in the future. This part assumes that MakeOutputModel.h does not need to
> retain interface compatibility.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/makeoutputdelegate.h 439d845 
>   projectbuilders/makebuilder/makeoutputdelegate.cpp b3d9002 
>   projectbuilders/makebuilder/makeoutputmodel.h 5ac4553 
>   projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e 
> 
> Diff: http://git.reviewboard.kde.org/r/100738/diff
> 
> 
> Testing
> -------
> 
> Tested functionality by building C++ code (with gcc) which exhibits the "Non-matching function call" error
> (e.g. by intentionally omitting a required parameter to a function call).
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110301/21ce3189/attachment.html>