<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100738/">http://git.reviewboard.kde.org/r/100738/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2011, 11:31 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100738/diff/1/?file=10087#file10087line41" style="color: black; font-weight: bold; text-decoration: underline;">projectbuilders/makebuilder/makeoutputmodel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MakeOutputModel : public QAbstractListModel, public KDevelop::IOutputViewModel</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Custom</span>Item</span> <span class="o">=</span> <span class="mi">4</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Action</span>Item</span> <span class="o">=</span> <span class="mi">4</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you change the order of the enumerees?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just wanted to make the relation to WarningItem/ErrorItem clear by grouping them.
(I think the specific numbering scheme is of no interest outside of MakeOutputModel and MakeOutputView,
so I am not sure why it would make sense to keep an explicit numbering at all?)
Anyway, the whole "InformationItem" part is optional, we could just handle the "note" the same way
as a warning, but I thought in the future one might want to change the layout/behaviour of
this class of compiler messages.
I can also submit a simplified patch without the InformationItem stuff if you prefer.</pre>
<br />
<p>- Manuel</p>
<br />
<p>On February 24th, 2011, 11:01 p.m., Manuel Massing wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Manuel Massing.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2011, 11:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When gcc encounters a non-matching function call, it spits out a
list of candidate methods. This patch makes the lines with candidate methods
clickable, so one can jump to the declaration.
The patch also introduces a differentiation between informative/warning
messages, which is not really necessary for this patch, but might prove useful
in the future. This part assumes that MakeOutputModel.h does not need to
retain interface compatibility.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested functionality by building C++ code (with gcc) which exhibits the "Non-matching function call" error
(e.g. by intentionally omitting a required parameter to a function call).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/makebuilder/makeoutputdelegate.h <span style="color: grey">(439d845)</span></li>
<li>projectbuilders/makebuilder/makeoutputdelegate.cpp <span style="color: grey">(b3d9002)</span></li>
<li>projectbuilders/makebuilder/makeoutputmodel.h <span style="color: grey">(5ac4553)</span></li>
<li>projectbuilders/makebuilder/makeoutputmodel.cpp <span style="color: grey">(09bb72e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100738/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>