Review Request: Make it easier to reach buttons on the edges

Alexander Dymo adymo at kdevelop.org
Mon Jun 6 10:31:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101506/#review3713
-----------------------------------------------------------


The UI was completely changed, so this patch doesn't solve the problem. I've committed the proper fix in rev. b10df1c.

- Alexander


On June 4, 2011, 3:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101506/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 3:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When KDevelop window is maximized, the buttons on the left and right edges of the window could be easier to reach. Right now there is a 2 pixel gap between the button and the border, which makes it impossible to reach the button by throwing the mouse to the edge.
> 
> Attached simple patch just set the margin to 0. I am not sure however if it makes sense to keep the define if it is set to 0. If you prefer me to get rid of the define and replace its usage with plain 0, tell me.
> 
> 
> Diffs
> -----
> 
>   sublime/ideallayout.h 06adbe7 
> 
> Diff: http://git.reviewboard.kde.org/r/101506/diff
> 
> 
> Testing
> -------
> 
> See attached before/after screenshot.
> 
> 
> Screenshots
> -----------
> 
> Before - After
>   http://git.reviewboard.kde.org/r/101506/s/174/
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110606/158b2eb7/attachment.html>


More information about the KDevelop-devel mailing list