Review Request: Source formatter settings: fix emitting changed signal when kate modeline checkbox gets unchecked

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101864/#review4702
-----------------------------------------------------------

Ship it!


yep, good catch. please commit or provide patch in "git format-patch" format

- Milian


On July 6, 2011, 12:04 p.m., Davide Simoncelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101864/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 12:04 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Suppose kate modeline checkbox is checked in source formatter settings and you want to uncheck it.
> 
> Signal changed(bool) is emitted with argument 'false' and so the module does not keep track of this unsaved change.
> 
> 
> Diffs
> -----
> 
>   shell/settings/sourceformattersettings.cpp e1cc613 
> 
> Diff: http://git.reviewboard.kde.org/r/101864/diff
> 
> 
> Testing
> -------
> 
> Compiled, installed, and tested.
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110713/b1c86767/attachment.html>