Review Request: Source formatter settings: fix emitting changed signal when kate modeline checkbox gets unchecked

Davide Simoncelli netcelli.tux at gmail.com
Wed Jul 6 12:04:24 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101864/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Suppose kate modeline checkbox is checked in source formatter settings and you want to uncheck it.

Signal changed(bool) is emitted with argument 'false' and so the module does not keep track of this unsaved change.


Diffs
-----

  shell/settings/sourceformattersettings.cpp e1cc613 

Diff: http://git.reviewboard.kde.org/r/101864/diff


Testing
-------

Compiled, installed, and tested.


Thanks,

Davide

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110706/cd38c43c/attachment.html>


More information about the KDevelop-devel mailing list