Review Request: Review Board: sort repositories alphabetically in review patch dialog

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101869/#review4501
-----------------------------------------------------------


next time please try to compile it before submitting ;-) I didn't catch it when looking at the diff, but it's ->repositories-> and not ->repositories()->...

fixed in master already, but take some more care in future please

- Milian


On July 6, 2011, 4:34 p.m., Davide Simoncelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101869/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 4:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Review path dialog for Review Board plugin does not sort repositories in alphabetical order and it may be hard to find the right repository.
> 
> This patch alters the insert policy of combo box so repositories are inserted in the alphabetic order.
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewpatchdialog.cpp 7267071 
> 
> Diff: http://git.reviewboard.kde.org/r/101869/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110707/68fe3630/attachment.html>