Review Request: Review Board: sort repositories alphabetically in review patch dialog

[Aleix Pol Gonzalez]

> On July 6, 2011, 9:30 p.m., Aleix Pol Gonzalez wrote:
> > It's always good to have things sorted.
> > 
> > But btw, where do we list repositories...?
> > 
> >
> 
> Davide Simoncelli wrote:
>     When you are in Review area and you would export diff to Review Board.
> 
> Aleix Pol Gonzalez wrote:
>     ah yes. cool!
> 
> Aleix Pol Gonzalez wrote:
>     Can you commit yourself or you need us to do so?
> 
> Davide Simoncelli wrote:
>     Ops sorry. I committed it this morning but I forgot to add "REVIEW: <id>" in the commit message so I clicked "Submitted" button on review board. Is it ok?

It's ok, just close the review yourself.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101869/#review4477
-----------------------------------------------------------


On July 6, 2011, 4:34 p.m., Davide Simoncelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101869/
> -----------------------------------------------------------
> 
> (Updated July 6, 2011, 4:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Review path dialog for Review Board plugin does not sort repositories in alphabetical order and it may be hard to find the right repository.
> 
> This patch alters the insert policy of combo box so repositories are inserted in the alphabetic order.
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewpatchdialog.cpp 7267071 
> 
> Diff: http://git.reviewboard.kde.org/r/101869/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110707/f30cb676/attachment.html>