Review Request: Fixes to include file completion items

Dmitry Risenberg dmitry.risenberg at gmail.com
Sat Jan 22 22:45:57 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100346/
-----------------------------------------------------------

(Updated Jan. 22, 2011, 10:45 p.m.)


Review request for KDevelop.


Changes
-------

@Milian:
Added unit tests for both cases.

@David:
Right, it should be out of 'if' - fixed.


Summary
-------

1) Fix file path shown in extended info when completing an include directive (file name was duplicated).
2) Do not add more than one completion widget items that refer to the same file. This may happen for

#include "../libdiff2

and include path containing <some_path>/settings and <some_path>/libdiff2.


Diffs (updated)
-----

  languages/cpp/cpputils.cpp 7b1b9a46028fde041407fc818f873dd914d32767 
  languages/cpp/tests/test_cppcodecompletion.h 625d3b7e624e2ba27b74af227897a11600243510 
  languages/cpp/tests/test_cppcodecompletion.cpp 2a82db1749aa98f6b0b56068b074a64338535254 

Diff: http://git.reviewboard.kde.org/r/100346/diff


Testing
-------


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110122/bbac913d/attachment.html>


More information about the KDevelop-devel mailing list