Review Request: Fixes to include file completion items

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100346/#review826
-----------------------------------------------------------


Before committing this, please consider my comment.


languages/cpp/cpputils.cpp
<http://git.reviewboard.kde.org/r/100346/#comment609>

    Why is basePath not set if !prependAddedPathToName, is this intentional?


- David


On Jan. 10, 2011, 1:37 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100346/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 1:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> 1) Fix file path shown in extended info when completing an include directive (file name was duplicated).
> 2) Do not add more than one completion widget items that refer to the same file. This may happen for
> 
> #include "../libdiff2
> 
> and include path containing <some_path>/settings and <some_path>/libdiff2.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpputils.cpp 7b1b9a46028fde041407fc818f873dd914d32767 
> 
> Diff: http://git.reviewboard.kde.org/r/100346/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110112/f7393f55/attachment.html>